Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide playfield layer with HUD #28062

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

peppy
Copy link
Member

@peppy peppy commented May 2, 2024

Touched on in #12039. I think this makes sense - things which are attached to the playfield are expected to always be attached and not disappear. Something like an osu!mania health bar.

This gives users a way to make elements always display (regardless of the HUD hide setting) which is also cool.

@bdach bdach self-requested a review May 2, 2024 10:45
@bdach
Copy link
Collaborator

bdach commented May 2, 2024

I don't particularly have anything against this. I suppose this does what it claims to do. Not sure how users at large will react to this change, and I would hope that eventually the visibility can be adjusted on a per-element basis.

That said no functional objections here.

@bdach bdach merged commit 0e11ce7 into ppy:master May 2, 2024
13 of 17 checks passed
@Walavouchey
Copy link
Member

I would hope that eventually the visibility can be adjusted on a per-element basis

i'll also note that this change doesn't allow "always visible" elements on the playfield layer to be anchored to the sides or corners of the screen (such as a hit error bar on the bottom). they instead move around when scaling the playfield

@bdach
Copy link
Collaborator

bdach commented May 3, 2024

Well aware yes.

@peppy peppy deleted the dont-hide-playfield branch May 4, 2024 04:28
@april83c
Copy link

I personally think the decision of "should this be attached to the screen or the playfield" and the decision of "should this always show" should be separate, but not that it should be a checkbox in the element properties; the layer system is what makes the most sense to use as "when should this show", and so I think attaching stuff to the screen or playfield should instead be decided in the right-click menu's Anchor selection -- maybe with some better UI than just a list?

Attaching the decision of "should this be attached to the screen or the playfield" to the existing layer system just blurs the lines on what the layer system is supposed to be, and limits options

@april83c
Copy link

I guess what I'm imagining is something like this? (except executed better... this is just a quick concept to convey the idea lol)

image

@bdach
Copy link
Collaborator

bdach commented May 18, 2024

@april83c I don't foresee us going in this direction. What you propose is more complicated in understanding than a visibility toggle. Users are already struggling to understand the anchor system as is; your mockup looks cool but is a nightmare to explain to users imo.

As has been stated above this change is a stopgap measure at best.

@april83c
Copy link

@april83c I don't foresee us going in this direction. What you propose is more complicated in understanding than a visibility toggle. Users are already struggling to understand the anchor system as is; your mockup looks cool but is a nightmare to explain to users imo.

As has been stated above this change is a stopgap measure at best.

The point I'm making is not to use that exact design, the point I'm making is to try to think of some better UI for this that allows for more options. I was just throwing something out there that could be built off of, so maybe someone sees it and gets a better idea

@peppy
Copy link
Member Author

peppy commented May 19, 2024

I kinda like the UI proposal, with a bit more refining it could actually be a better way of exposing anchors/origins to end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants